Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling: type class vs. typeclass #441

Closed
fthomas opened this issue Aug 11, 2015 · 6 comments · Fixed by #446
Closed

Spelling: type class vs. typeclass #441

fthomas opened this issue Aug 11, 2015 · 6 comments · Fixed by #446

Comments

@fthomas
Copy link
Member

fthomas commented Aug 11, 2015

I've noticed that we are inconsistent wrt to the spelling of "type class" and "typeclass". The README uses mostly "type class" while docs/src/site/index.md uses "typeclass" exclusively. For the sake of robotic consistency, can we agree on one spelling?
@travisbrown
Copy link
Contributor

👍 for consistency, and 👍 for two words.

There's a discussion of this question at the end of the second section of the Typeclassopedia, which makes an argument from history for "type class".

@non
Copy link
Contributor

non commented Aug 11, 2015

I agree with "type class" and also with the push for consistency. Thanks for noticing this.

@adelbertc
Copy link
Contributor

👍 type class

@milessabin
Copy link
Member

+1

@fthomas
Copy link
Member Author

fthomas commented Aug 11, 2015

I'm also for "type class". As an additional data point, Wikipedia also uses two words: https://en.wikipedia.org/wiki/Type_class

I'll prepare a PR then later this week.

fthomas added a commit to fthomas/cats that referenced this issue Aug 14, 2015
@fthomas
Make the spelling of "type class" consistent
bc9b07d 
This changes all occurences of "typeclass" to "type class" in user
visible places. Filenames or technical strings like "typeclasses.md"
or the Jekyll "typeclasses" section are not changed.

closes: typelevel#441
@fthomas fthomas mentioned this issue Aug 14, 2015
Merged
@fthomas
Copy link
Member Author

fthomas commented Aug 14, 2015

Closed by #446

@fthomas fthomas closed this as completed Aug 14, 2015
@fthomas fthomas mentioned this issue Aug 24, 2015
Merged
philwills pushed a commit to philwills/cats that referenced this issue Aug 29, 2015
typeclass -> type class, as per typelevel#441
775a3f3 
Thanks for the heads up @fthomas
@fthomas fthomas mentioned this issue Dec 13, 2015
Merged
fthomas added a commit to fthomas/cats that referenced this issue Jun 19, 2016
@fthomas
typeclass -> type class
a69f9dd 
As agreed upon in typelevel#441.
@fthomas fthomas mentioned this issue Jun 19, 2016
Merged
ceedubs added a commit to ceedubs/cats that referenced this issue Jun 19, 2016
@ceedubs
Add scalastyle rule for "type class"
548e74d 
Instead of "typeclass" -- this decision was made in typelevel#441.
@fthomas fthomas mentioned this issue Aug 23, 2016
Merged
@kailuowang kailuowang mentioned this issue Sep 17, 2018
Merged
@asakaev asakaev mentioned this issue May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the spelling of "type class" consistent fthomas/cats
5 participants
@milessabin @fthomas @non @travisbrown @adelbertc