Adding CoflatMap and tests to WriterT and fixed laws for CoflatMap #1049
Conversation
| implicit val F: Functor[ListWrapper] = ListWrapper.functor | ||
|
|
||
| CoflatMap[WriterT[ListWrapper, Int, ?]] | ||
| checkAll("WriterT[Listwrapper, Int, ?]", CoflatMapTests[WriterT[ListWrapper, Int, ?]].coflatMap[Int, Int, Int]) |
There was a problem hiding this comment.
need to check serializability
| @@ -87,8 +87,7 @@ private[data] sealed abstract class WriterTInstances0 extends WriterTInstances1 | |||
| implicit val L0: Monoid[L] = L | |||
| } | |||
|
|
|||
| implicit def writerTIdFunctor[L]: Functor[WriterT[Id, L, ?]] = | |||
| writerTFunctor[Id, L] | |||
| def writerTIdFunctor[L]: Functor[WriterT[Id, L, ?]] = writerTIdCoflatMap | |||
There was a problem hiding this comment.
We should be able to delete this now that writerTIdCoflatMap exists. You might want to move it up to where this was.
There was a problem hiding this comment.
If I move it up, the implicit conflicts with writerTIdFlatMap when there is a Semigroup for L, as they are both Functors
There was a problem hiding this comment.
Ah I see. Glad we have tests for that! :). Do things work if you just remove this writerTIdFunctor?
|
Thanks @zainab-ali! This is definitely a nice change. I think it allows us to remove a couple |
| @@ -168,7 +171,9 @@ private[data] sealed abstract class WriterTInstances6 extends WriterTInstances7 | |||
| } | |||
|
|
|||
| private[data] sealed abstract class WriterTInstances7 { | |||
| implicit def writerTFunctor[F[_], L](implicit F: Functor[F]): Functor[WriterT[F, L, ?]] = new WriterTFunctor[F, L] { | |||
|
|
|||
| implicit def writerTCoflatMap[F[_], L](implicit F: Functor[F]): WriterTCoflatMap[F, L] = | |||
There was a problem hiding this comment.
I think the return type here should be CoflatMap[WriterT[F, L, ?]]
|
@zainab-ali looks great! Thanks again. 👍 |
|
LGTM 👍 |
Adding a
CoflatMapinstance toWriterT, as required in #620Added all laws in
CoflatMapLawstoCoflatMapTests