-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left-adjoint of forgetful functor #1056
Conversation
@@ -424,7 +424,7 @@ The above forgetful functor takes a `Monad` and: | |||
- finally keeps the *functor* part (e.g. the `map` function) | |||
|
|||
By reversing all arrows to build the left-adjoint, we deduce that the | |||
forgetful functor is basically a construction that: | |||
free functor is basically a construction that: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this context the author really meant this to read free monad. Thanks for pointing out the problem. Does this make sense to you?
I agree. He certainly means Free monad in this context. Free functor being the more general concept of a left-adjoint of a forgetful functor. Another issue I see is that pure is not the "applicative" part, as both pure and flatmap are part of the monad structure: applicative is simply a by product of being a monad. |
@Madder thanks for pointing this out. It sounds like we all agree that it should be changed to free monad. As for at the "applicative part" - I can see the author's point (no pun intended, but I'll go with it) that by taking a Would you be interested in submitting a PR for any changes you'd like to see? |
@ceedubs Possibly a stupid question, but don't you need an |
@Madder oops you are quite right :) |
Current coverage is 88.13%@@ master #1056 diff @@
==========================================
Files 224 224
Lines 2839 2839
Methods 2782 2782
Messages 0 0
Branches 52 52
==========================================
Hits 2502 2502
Misses 337 337
Partials 0 0
|
@ceedubs I've updated the PR with free monad instead free functor. I've also replaced applicative with pointed which is more accurate but I'm not sure whether it fits in that context anymore... Let me know if you prefer another formulation. I can change the PR accordingly or submit a new one if preferable. |
@Madder thank you. If someone wants to further refine this, they should feel free to, but 👍 from me. |
👍 looks good to me. thanks for working on this! |
Isn't it supposed to be the free functor?