Fix Inject instance and reduceRightToOption null behavior #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.88%@@ master #1096 diff @@
==========================================
Files 226 226
Lines 2916 2916
Methods 2865 2865
Messages 0 0
Branches 48 48
==========================================
Hits 2592 2592
Misses 324 324
Partials 0 0
|
edmundnoble
changed the title
|
👍 |
|
👍 Great catch, thanks! |
|
Should we add a law that checks this property, and/or an explicit test of the null behavior with option? |
|
I'm going to just merge this -- we can add a test in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject.prj(null)with the provided reflexive Inject instance (Inject[F, F]) returns None, butInject.inj(null)returns null. I am fairly sure that inj and prj should be mutual inverses, this fixes that. It works the same way now as in Scalaz.