Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Monad constraint for SemigroupK for XorT #1108

Closed
wants to merge 2 commits into from

Conversation

yilinwei
Copy link
Contributor

@yilinwei yilinwei commented Jun 9, 2016

Can form a SemigroupK with an Applicative rather than Monad

@non
Copy link
Contributor

non commented Jun 9, 2016

Looks good. 👍

@codecov-io
Copy link

Current coverage is 88.62%

Merging #1108 into master will decrease coverage by <.01%

  1. 3 files (not in diff) in .../main/scala/cats/std were modified. more
@@             master      #1108   diff @@
==========================================
  Files           227        227          
  Lines          2946       2945     -1   
  Methods        2890       2888     -2   
  Messages          0          0          
  Branches         53         54     +1   
==========================================
- Hits           2611       2610     -1   
  Misses          335        335          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 5cf9da3...632d545

@yilinwei
Copy link
Contributor Author

#1106 explains why this Applicative makes no sense and should be using a Nested.

@yilinwei yilinwei closed this Jun 10, 2016
@yilinwei yilinwei deleted the xortapplicative branch June 10, 2016 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants