Add return type in Traverse example #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following line says note the return type but it is not in the definition.
Current coverage is 88.79%@@ master #1185 diff @@
==========================================
Files 233 233
Lines 3079 3079
Methods 3025 3025
Messages 0 0
Branches 51 51
==========================================
Hits 2734 2734
Misses 345 345
Partials 0 0
|
|
👍 |
1 similar comment
|
👍 |
|
Thanks @richardmiller! I would also be inclined to mark this as scala> def profilesFor(users: List[User]) = users.map(userInfo)
profilesFor: (users: List[User])List[scala.concurrent.Future[Profile]]Now that the return type is specified explicitly the output line can probably just be omitted. What do you think? |
richardmiller-zz
pushed a commit
to richardmiller-zz/cats
that referenced
this pull request
Jul 12, 2016
As per comment on typelevel#1185
richardmiller-zz
pushed a commit
to richardmiller-zz/cats
that referenced
this pull request
Jul 13, 2016
As with typelevel#1185 the return type is referred to in following line but not in the code example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following line says note the return type but it is not in the definition.