Change format of NonEmptyVector.show #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up on several small suggestions from comments in typelevel#1137. The only meaningful modification is changing the format of `show` from something like `NonEmptyVector(Vector(1, 2, 3))` to something like `NonEmptyVector(1, 2, 3)`. I've also added a `length` method to `NonEmptyVector`.
|
👍 |
| @@ -138,7 +144,7 @@ private[data] sealed trait NonEmptyVectorInstances { | |||
|
|
|||
| override def split[A](fa: NonEmptyVector[A]): (A, Vector[A]) = (fa.head, fa.tail) | |||
|
|
|||
| override def size[A](fa: NonEmptyVector[A]): Long = 1 + fa.tail.size.toLong | |||
| override def size[A](fa: NonEmptyVector[A]): Long = fa.length.toLong | |||
|
👍 LGTM pending the |
|
👍 |
Current coverage is 89.20%@@ master #1203 diff @@
==========================================
Files 234 234
Lines 3137 3141 +4
Methods 3083 3084 +1
Messages 0 0
Branches 52 55 +3
==========================================
+ Hits 2797 2802 +5
+ Misses 340 339 -1
Partials 0 0
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on several small suggestions from comments in #1137. The
only meaningful modification is changing the format of
showfromsomething like
NonEmptyVector(Vector(1, 2, 3))to something likeNonEmptyVector(1, 2, 3).I've also added a
lengthmethod toNonEmptyVector.