[Do not merge] Don't run stack-safety tests for JS #1246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a shot in the dark attempting to fix typelevel#1242. The idea is that we can mark certain tests as slow and not run them when running JS tests. Currently I've done this for all of the stack-safety tests that I can find. I don't really like this solution, but currently almost every PR is resulting in a failed build, which is really problematic. One thing that we could do is get rid of the `Platform.isJs` branch of the `slowTest` implementation locally just before a release to make sure that these tests all pass on JS. I think we only really run into these issues on Travis CI.
Current coverage is 90.13% (diff: 100%)@@ master #1246 diff @@
==========================================
Files 243 243
Lines 3285 3285
Methods 3231 3231
Messages 0 0
Branches 51 51
==========================================
Hits 2961 2961
Misses 324 324
Partials 0 0
|
|
This build passed the first time. I'm going to restart it to try to check whether that was a coincidence. |
|
The 2.10 build failed on the second run :( |
ceedubs
changed the title
|
The 2.11 build failed on the third run. I don't think this change really helps :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot in the dark attempting to fix #1242.
The idea is that we can mark certain tests as slow and not run them when
running JS tests. Currently I've done this for all of the stack-safety
tests that I can find.
I don't really like this solution, but currently almost every PR is
resulting in a failed build, which is really problematic. One thing that
we could do is get rid of the
Platform.isJsbranch of theslowTestimplementation locally just before a release to make sure that these
tests all pass on JS. I think we only really run into these issues on
Travis CI.