[Do not merge] Experimenting with stabilizing builds #1250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 561ee92. We've had a lot of failed builds recently and it seems to coincide with when we updated from Scala.js 0.6.8 to 0.6.11. This is an experiment to see if reverting that change stabilizes the build.
This is a shot in the dark attempting to fix typelevel#1242. The idea is that we can mark certain tests as slow and not run them when running JS tests. Currently I've done this for all of the stack-safety tests that I can find. I don't really like this solution, but currently almost every PR is resulting in a failed build, which is really problematic. One thing that we could do is get rid of the `Platform.isJs` branch of the `slowTest` implementation locally just before a release to make sure that these tests all pass on JS. I think we only really run into these issues on Travis CI.
Current coverage is 90.13% (diff: 100%)@@ master #1250 diff @@
==========================================
Files 243 243
Lines 3285 3285
Methods 3231 3231
Messages 0 0
Branches 51 51
==========================================
Hits 2961 2961
Misses 324 324
Partials 0 0
|
|
It might be memory related. I am going to experiment with separating the tasks in travis, here is the experiment PR #1254 |
|
I think #1256 fixes the build. The problem is still most likely memory. |
|
Thanks again @kailuowang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to use this PR to take shots in the dark at stabilizing builds. Don't merge this branch and be aware that I'm likely to force push to it.
It has been
0builds since the last build failure.