-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port #1215 to EitherT #1301
Merged
Merged
Port #1215 to EitherT #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a3b3d6
to
d6841a5
Compare
Current coverage is 90.60% (diff: 100%)@@ master #1301 diff @@
==========================================
Files 235 235
Lines 3606 3607 +1
Methods 3546 3549 +3
Messages 0 0
Branches 56 54 -2
==========================================
+ Hits 3267 3268 +1
Misses 339 339
Partials 0 0
|
👍 |
1 similar comment
👍 |
This was referenced Aug 20, 2016
non
pushed a commit
to non/cats
that referenced
this pull request
Aug 20, 2016
Due to a communications error we merged some PRs which we had been planning to keep out of master until after 0.7.0. Since one of them (typelevel#1289) was large and long-running, it was difficult to undo this merge in an automated way. This commit represents the following: 1. Downloaded patches for PRs 1301 and 1289 from Github 2. Tried to reverse-apply them (-R) 3. Fixed rejections/failures manually 4. Got code compiling and tests passing The code is now different than it was before the PRs were merged, but things *seem* to be in a reasonable state. I'm keeping all these changes in one commit so that it will be easier to "reverse" this once 0.7.0 is relaesed.
non
pushed a commit
to non/cats
that referenced
this pull request
Aug 20, 2016
Due to a communications error we merged some PRs which we had been planning to keep out of master until after 0.7.0. Since one of them (typelevel#1289) was large and long-running, it was difficult to undo this merge in an automated way. This commit represents the following: 1. Downloaded patches for PRs 1301 and 1289 from Github 2. Tried to reverse-apply them (-R) 3. Fixed rejections/failures manually 4. Got code compiling and tests passing The code is now different than it was before the PRs were merged, but things *seem* to be in a reasonable state. I'm keeping all these changes in one commit so that it will be easier to "reverse" this once 0.7.0 is relaesed.
non
pushed a commit
to non/cats
that referenced
this pull request
Aug 20, 2016
Due to a communications error we merged some PRs which we had been planning to keep out of master until after 0.7.0. Since one of them (typelevel#1289) was large and long-running, it was difficult to undo this merge in an automated way. This commit represents the following: 1. Downloaded patches for PRs 1301 and 1289 from Github 2. Tried to reverse-apply them (-R) 3. Fixed rejections/failures manually 4. Got code compiling and tests passing The code is now different than it was before the PRs were merged, but things *seem* to be in a reasonable state. I'm keeping all these changes in one commit so that it will be easier to "reverse" this once 0.7.0 is relaesed.
non
pushed a commit
to non/cats
that referenced
this pull request
Aug 20, 2016
Due to a communications error we merged some PRs which we had been planning to keep out of master until after 0.7.0. Since one of them (typelevel#1289) was large and long-running, it was difficult to undo this merge in an automated way. This commit represents the following: 1. Downloaded patches for PRs 1301 and 1289 from Github 2. Tried to reverse-apply them (-R) 3. Fixed rejections/failures manually 4. Got code compiling and tests passing The code is now different than it was before the PRs were merged, but things *seem* to be in a reasonable state. I'm keeping all these changes in one commit so that it will be easier to "reverse" this once 0.7.0 is relaesed.
non
pushed a commit
to non/cats
that referenced
this pull request
Aug 20, 2016
Due to a communications error we merged some PRs which we had been planning to keep out of master until after 0.7.0. Since one of them (typelevel#1289) was large and long-running, it was difficult to undo this merge in an automated way. This commit represents the following: 1. Downloaded patches for PRs 1301 and 1289 from Github 2. Tried to reverse-apply them (-R) 3. Fixed rejections/failures manually 4. Got code compiling and tests passing The code is now different than it was before the PRs were merged, but things *seem* to be in a reasonable state. I'm keeping all these changes in one commit so that it will be easier to "reverse" this once 0.7.0 is relaesed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.