Remove references to Monad from CoflatMap doc #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc for `coflatMap` states that the value is in a Monadic context, which can be confusing, because: - there is no Monad constraint on the context (the example being a Monad is incidental) - it is *more likely* to be a Comonad
Current coverage is 90.60% (diff: 100%)@@ master #1304 diff @@
==========================================
Files 235 235
Lines 3607 3607
Methods 3549 3549
Messages 0 0
Branches 54 54
==========================================
Hits 3268 3268
Misses 339 339
Partials 0 0
|
|
Makes sense to me. 👍 We'll merge this after 0.7.0 is released. Thanks! |
|
Thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies in advance for this, if I had the ability to label this PR, it would definitely be something along the lines of 'nitpick'.
The doc for
coflatMapstates that the value is in a Monadic context, which can be confusing, because: