Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doctest plugin / use same command for release and travis build #1322

Merged
merged 6 commits into from
Aug 30, 2016

Conversation

kailuowang
Copy link
Contributor

  1. disabled doctest plugin on all js projects which was enabled by this [commit])67eacc7)
  2. use the same commands for travis and release
  3. added freeJS test to validateJS
  4. try use aggregated project test as much as possible (will see if travis can handle)

@codecov-io
Copy link

codecov-io commented Aug 23, 2016

Current coverage is 91.39% (diff: 100%)

Merging #1322 into master will decrease coverage by 0.08%

@@             master      #1322   diff @@
==========================================
  Files           234        237     +3   
  Lines          3543       3567    +24   
  Methods        3484       3502    +18   
  Messages          0          0          
  Branches         59         64     +5   
==========================================
+ Hits           3241       3260    +19   
- Misses          302        307     +5   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 79d5f53...184ad2f

@tkawachi
Copy link

Hi @kailuowang, sbt-doctest requires JvmPlugin so that it's not enabled automatically in ScalaJS project. Is it enabled without disablePlugin() in this case?

https://github.com/tkawachi/sbt-doctest/blob/master/src/main/scala/com/github/tkawachi/doctest/DoctestPlugin.scala#L34-L35

@kailuowang
Copy link
Contributor Author

kailuowang commented Aug 23, 2016

@tkawach yes, it's enabled without the disablePlugin, I am not sure if requiring JvmPlugin disable it for js projects. See scalajs plugin requires JvmPlugin as well.
https://github.com/scala-js/scala-js/blob/master/sbt-plugin/src/main/scala/org/scalajs/sbtplugin/ScalaJSPlugin.scala#L29

@non
Copy link
Contributor

non commented Aug 23, 2016

I'd love to see this issue fixed, so let's give it a shot. 👍

Thanks for working on this @kailuowang!

@fthomas
Copy link
Member

fthomas commented Aug 26, 2016

In refined I added doctestGenTests := Seq.empty to the common settings for JS subprojects. This might save us from adding all those disablePlugins(DoctestPlugin).

@kailuowang
Copy link
Contributor Author

@fthomas that worked, thanks!

@fthomas
Copy link
Member

fthomas commented Aug 30, 2016

👍

I think you can now also remove import com.github.tkawachi.doctest.DoctestPlugin, right?

@kailuowang
Copy link
Contributor Author

@fthomas good catch. Fixed.

@fthomas fthomas merged commit 449e0b0 into typelevel:master Aug 30, 2016
@kailuowang kailuowang deleted the topics/fix-js-doctest branch August 30, 2016 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants