Add consistency laws for .combineAll and .combineAllOption. #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests will catch sitautions where the optimized methods are broken (i.e. become inconsistent with the behavior of .combine). These tests caught an issue with Monoid[Map[K, V]].combineAll, which was broken. Fixes typelevel#1346.
Current coverage is 91.73% (diff: 100%)@@ master #1347 diff @@
==========================================
Files 237 237
Lines 3567 3571 +4
Methods 3502 3505 +3
Messages 0 0
Branches 64 65 +1
==========================================
+ Hits 3260 3276 +16
+ Misses 307 295 -12
Partials 0 0
|
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests will catch sitautions where the optimized methods are
broken (i.e. become inconsistent with the behavior of .combine).
These tests caught an issue with Monoid[Map[K, V]].combineAll, which
was broken.
Fixes #1346.