Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaultTailRecM from monad doc #1444

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

guersam
Copy link
Contributor

@guersam guersam commented Oct 27, 2016

Replaced defaultTailRecM with a handwritten example.

@adelbertc
Copy link
Contributor

Hmm how was this passing tut before?

@codecov-io
Copy link

Current coverage is 92.19% (diff: 100%)

Merging #1444 into master will not change coverage

@@             master      #1444   diff @@
==========================================
  Files           242        242          
  Lines          3615       3615          
  Methods        3546       3546          
  Messages          0          0          
  Branches         69         69          
==========================================
  Hits           3333       3333          
  Misses          282        282          
  Partials          0          0          

Powered by Codecov. Last update 25e9628...2bfaaac

@non
Copy link
Contributor

non commented Oct 27, 2016

@adelbertc Maybe it was imported? Anyway, LGTM 👍

@kailuowang
Copy link
Contributor

kailuowang commented Oct 27, 2016

@non that method should've been already deleted a while ago. So it's a puzzle to me as well how tut passed...
This change LGTM 👍

@non non merged commit 91242d0 into typelevel:master Oct 27, 2016
@guersam
Copy link
Contributor Author

guersam commented Oct 28, 2016

The example on the site is rendered as markdown, not scala and it seems related to the suspicious tut passing. http://typelevel.org/cats/typeclasses/monad.html#composition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants