Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Scala 2.12.0 #1457

Merged
merged 10 commits into from
Nov 8, 2016
Merged

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented Nov 7, 2016

This PR includes @adamnfish's changes from #1450, together with the rest of the stuff we need for 2.12.0.

Note that because of an issue in the 1.5.0 release of the sbt-scoverage plugin, it necessary to set the Scoverage compiler plugin version explicitly for the build:

coverageScalacPluginVersion := "1.3.0"

The issue should be fixed in the next sbt-scoverage release, and then it should be possible to remove that line.

@codecov-io
Copy link

codecov-io commented Nov 7, 2016

Current coverage is 92.20% (diff: 100%)

Merging #1457 into master will not change coverage

@@             master      #1457   diff @@
==========================================
  Files           242        242          
  Lines          3618       3618          
  Methods        3550       3550          
  Messages          0          0          
  Branches         68         68          
==========================================
  Hits           3336       3336          
  Misses          282        282          
  Partials          0          0          

Powered by Codecov. Last update 9af39fb...6e4d727

@kailuowang
Copy link
Contributor

Looks like there is a problem with the catalysts release. I am working on it now.

@travisbrown
Copy link
Contributor Author

Thanks, @kailuowang! Looks like the missing artifact is there now, so hopefully this time it'll work.

@mandubian
Copy link
Contributor

👍

1 similar comment
@kailuowang
Copy link
Contributor

👍

@alexandru
Copy link
Member

👍

@adamnfish
Copy link
Contributor

Thanks, @travisbrown!

@gslowikowski
Copy link

coverageScalacPluginVersion := "1.3.0" setting can be removed from build.sbt.

@travisbrown
Copy link
Contributor Author

@gslowikowski How? Did you overwrite the 1.5.0 release on Maven Central? (Is that even possible?)

@travisbrown
Copy link
Contributor Author

@gslowikowski In any case since this only affects the build and is the same behavior you'd get without the line, I'd say let's get this PR merged asap and remove the line in a follow-up PR.

@non
Copy link
Contributor

non commented Nov 8, 2016

👍

@non non merged commit 086d710 into typelevel:master Nov 8, 2016
@non non removed the in progress label Nov 8, 2016
@gslowikowski
Copy link

@travisbrown sure, I just wanted to let you know, that I fixed the snapshot problem before syncing to Maven central

@travisbrown
Copy link
Contributor Author

@gslowikowski This is getting off-topic for this PR (now that it's merged it probably doesn't matter), but did you figure out why the artifacts made it to Sonatype releases but hadn't been synced to MC after more than a day?

@gslowikowski
Copy link

I didn't ask. I was happy, that because of this delay I could ask Sonatype team to break this buggy release. I've had similar problem in the past. That was something in their internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants