-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added instance table to docs, enhanced typeclass diagram #1565
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 240 240
Lines 3941 3941
Branches 141 138 -3
=======================================
Hits 3680 3680
Misses 261 261 Continue to review full report at Codecov.
|
This sort of solves #1287. |
aecd940
to
fe3f453
Compare
fe3f453
to
1ed71df
Compare
@kailuowang Regarding the svg issue, I think the problem might be related to Jekyll filtering: Could you please try to put below this line the next sbt config? includeFilter in Jekyll := "*.html" | "*.css" | "*.png" | "*.jpg" | "*.gif" | "*.js" | "*.swf" | "*.yml" | "*.md" | "*.svg" The trick would be using Let me know if that solves the issue. |
@juanpedromoreno that indeed fixed the issue. Thanks very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the graphic and the table are great.
@tpolecat The graph is amazing, though unfortunately it's a bit out of date on the cats-effect front since we had to make |
@kailuowang is it possible/desirable to link directly to the SVG in my repo so it gets updated automatically? |
@tpolecat it's certainly desirable from my point of view. In fact, that's the first thing I tried. I couldn't find a url of it that points to the latest version and with the right content type. Maybe you have to publish it to gh-pages? (or just make gh-pages your main branch?) |
The internet showed me this trick but I don't know if it's a reasonable long-term solution. Below the link is:
The embedded png file isn't showing up but I'm not sure what to do about that. I could just remove it, it doesn't really add anything. |
NonEmptyList is a monad, no? |
@tpolecat awesome! Just updated. I think a midterm solution is good enough for now. |
@johnynek good catch, fixed. |
@kailuowang I updated the infographic but it's not showing up on the cdn yet. It may be cached for a while. Update: it updated at some point so I think we're good. |
ping @johnynek. Do yo have time to take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff!
UPDATE: I switched to tpolecat's infographic.
But Don't merge yet, it seems to me that microsites doesn't support .svg files, see 47degrees/sbt-microsites#182SVG issue resolved ready to review/merge.
Originally from @alexknvl
The instance table
K:Monoid
)E: Semigroup
)E: Semigroup
)E:Monoid
)The typeclass infograph from @tpolecat