Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbols to FAQ #1573

Merged
merged 6 commits into from
May 12, 2017
Merged

Add symbols to FAQ #1573

merged 6 commits into from
May 12, 2017

Conversation

zainab-ali
Copy link
Contributor

Add symbols to FAQ, as discussed in #1384

@codecov-io
Copy link

codecov-io commented Mar 25, 2017

Codecov Report

Merging #1573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1573   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files         240      240           
  Lines        3941     3941           
  Branches      138      141    +3     
=======================================
  Hits         3680     3680           
  Misses        261      261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a90b61...64b8393. Read the comment docs.


Below is a list of symbols used in cats.

The `~>`, `⊥` and `⊤` symbols can be imported with `import cats._`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:<: and :≺: was added to cats package in #1557

@kailuowang
Copy link
Contributor

@zainab-ali do you plan to continue this one?

@zainab-ali
Copy link
Contributor Author

Yes - I think I've got all the symbols, but can't find a definitive way of checking. Any ideas are welcome.

@rossabaker
Copy link
Member

Would nicknames be useful here? I've heard "scream" or "cinnabon" for |@| and "spaceship" for <=> and condescension toward those who don't know. I don't want to encourage the jargon or especially the condescension, but maybe a slang column here could assist communication of these operators.

@zainab-ali
Copy link
Contributor Author

I like the idea - especially as part of the FAQ. I think @fommil had some ideas on names earlier.

@fommil
Copy link

fommil commented Apr 10, 2017

nice! I'm going to print this out and keep it on my desk

@zainab-ali
Copy link
Contributor Author

@rossabaker where / what is <=>? I just realized I missed it from the list

@rossabaker
Copy link
Member

I might have just had a Perl flashback with <=>.

There is a <-> in cats-laws.

@kailuowang
Copy link
Contributor

@zainab-ali got any time to continue this one, if not I'll be more than happy to take over.

@zainab-ali
Copy link
Contributor Author

Sorry for taking so long on this one.

I've added the cinnabon / scream nickname, but am having trouble thinking of others.
GitHub has suddenly decided that the | inside the code block for |@| is a table delimiter, hence the odd rendering. Jekyll renders the correct output, so this shouldn't be a problem on the site.

@kailuowang
Copy link
Contributor

@rossabaker , would you mind take another look?

@rossabaker
Copy link
Member

This is nice. The table works for me on GitHub if I escape the pipes in |@| with a backslash. I'm not sure what this does to Jekyll.

Only missing ones I can think of:

I thought we'd have more nicknames when I suggested it, but Cats doesn't have left fish (<=<), right fish (>=>), or spaceship (<=>), so I guess that column is going to be a bit sparse. That probably speaks well of Cats. 😄

@zainab-ali
Copy link
Contributor Author

Jekyll didn't like the backslashes for me. This post seems to do the trick, though it's somewhat of a mess. It works with both Jekyll and GitHub.

| `x === y` | equals | | `Eq[A]` | `eqv(x: A, y: A): Boolean` |
| `x =!= y` | not equals | | `Eq[A]` | `neqv(x: A, y: A): Boolean` |
| `fa >>= f` | flatMap | | `FlatMap[F[_]]` | `flatMap(fa: F[A])(f: A => F[B]): F[B]` |
| `fa >> fb` | followed by | | `FlatMap[F[_]]` | `followedBy(fa: F[A])(fb: F[B]): F[B]` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of #1537 there is also << (FlatMap#forEffect).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now added that

@peterneyens
Copy link
Collaborator

Sorry for the late feedback. If you want to add >>> , <<< and <<, I think this is good to go 👍

@zainab-ali
Copy link
Contributor Author

I've added >>>, <<< and <<

@zainab-ali
Copy link
Contributor Author

zainab-ali commented May 9, 2017

The build is failing with a python pip error - is this a transient issue?

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@edmundnoble
Copy link
Contributor

Is it perhaps worth it to include more fine-grained imports for the symbols than cats.implicits._?

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@kailuowang
Copy link
Contributor

@edmundnoble I agree. This PR is already a big improvement from what we have. Shall we merge it for now and work on the fine-grained imports in another PR?

@edmundnoble
Copy link
Contributor

SGTM @kailuowang. Let's get this in.

@kailuowang kailuowang merged commit 9f98924 into typelevel:master May 12, 2017
@kailuowang kailuowang added this to the 1.0.0-MF milestone Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants