Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/Tutorial -- Simplify Kleisli example #1588

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

RawToast
Copy link
Contributor

@RawToast RawToast commented Apr 4, 2017

First, I found the documentation to be a decent introduction to the concept -- so thanks!

I just found stating Returning to our earlier example and then using a different solution to the earlier example be misleading -- I ended up scrolling up the page thinking I had missed a step!

It would be clearer to use the same solution.

Amended second instance of parseAndReciprocal to use the same functions as in the earlier example.
@RawToast RawToast changed the title Simplify Kleisli example Docs/Tutorial -- Simplify Kleisli example Apr 4, 2017
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

codecov-io commented Apr 4, 2017

Codecov Report

Merging #1588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         249      249           
  Lines        3974     3974           
  Branches      138      138           
=======================================
  Hits         3673     3673           
  Misses        301      301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d205f...16149ed. Read the comment docs.

Copy link
Collaborator

@peterneyens peterneyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RawToast, makes sense 👍

@adelbertc adelbertc merged commit dbe4407 into typelevel:master Apr 4, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-MF Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants