-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Inject to InjectK #1596
Rename Inject to InjectK #1596
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 250 250
Lines 3992 3992
Branches 138 136 -2
=======================================
Hits 3717 3717
Misses 275 275
Continue to review full report at Codecov.
|
Makes sense to me. 👍 Can we also create a ticket for the new |
Sure, and I'll put up a PR up for Inject if this one gets merged. |
Thanks @andyscott this looks good to me. I only have one minor suggestion: there are a couple places that now say "InjectK type class as described in "Data types a la carte". This might be slightly confusing to readers, since that paper doesn't mention an |
@ceedubs Good call, I'll address that now |
1876aa8
to
e5ec454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andyscott! 👍 LGTM.
Rename
Inject
toInjectK
to be consistent with names/renames forEitherK
,FunctionK
,Tuple2K
, and friends. See #1589.This is a breaking API and breaking binary change.
Additionally, this opens the door to "re-introduce"
Inject
forEither
:Inject for Either would be useful when combining error algebras across domains with
Free
.