Include Id docs in the menu #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also moved the Id doc from the typeclasses dir to the datatypes dir, which seems like a better fit to me. This was inspired by [a prompt](https://gitter.im/typelevel/cats?at=58f5de53ad849bcf4295d321) in the Cats Gitter channel from @BenFradet. @BenFradet could you please review?
BenFradet
approved these changes
Apr 18, 2017
|
shouldn't the section be changed to |
|
@BenFradet good catch. I was having some trouble trying to build the site locally to test this :(. Change incoming. |
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 250 250
Lines 3989 3989
Branches 138 138
=======================================
Hits 3713 3713
Misses 276 276Continue to review full report at Codecov.
|
BenFradet
approved these changes
Apr 18, 2017
|
LGTM. thanks! Merged as a simple doc correction with one sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also moved the Id doc from the typeclasses dir to the datatypes
dir, which seems like a better fit to me.
This was inspired by a prompt in the Cats Gitter channel from @BenFradet. @BenFradet could you please review?