Add reducible docs #1777
Add reducible docs #1777
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 273 273
Lines 4554 4554
Branches 129 122 -7
=======================================
Hits 4376 4376
Misses 178 178Continue to review full report at Codecov.
|
LukaJCB
force-pushed
the
add-reducible-docs
branch
2 times, most recently
from
2c34aea
to
8f8c764
Compare
| `Reducible` extends the `Foldable` type class with additional `reduce` methods. | ||
|
|
||
| You may have come by one of the `reduce`, `reduceLeft` or `reduceOption` defined in Scala's standard collections. | ||
| `Reducible` offers exactly these methods with the guarantee, that the collection won't throw an exception at runtime, without having to reduce to an `Option`. |
There was a problem hiding this comment.
Minor: I don't think that you need a comma after "guarantee".
There was a problem hiding this comment.
I guess that years of Java have made me paranoid. Maybe "the collection won't throw an exception at runtime" is a bit of a strong guarantee. Maybe we should just say that these methods won't throw an exception due to a collection being empty? :)
|
Seems history got messed up? |
LukaJCB
force-pushed
the
add-reducible-docs
branch
from
5d17b91
to
663186f
Compare
|
Fixed! |
|
Sorry I dropped ball on this one. @LukaJCB for some reason Github conflict merge tool is not working for us. Do yo mind update this one and merge? |
|
I think it's fine actually, no? You guys just need to re-review to merge :) |
Looking for some early feedback on this, still mostly unstructured :)