Added more implementations of map2Eval #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hit a case where I wanted laziness with map2Eval and realized in many cases where we could have it, we do not. There were all the cases I saw that we missed, which I hope our existing tests cover.
Codecov Report
@@ Coverage Diff @@
## master #1819 +/- ##
==========================================
+ Coverage 94.88% 94.96% +0.07%
==========================================
Files 241 241
Lines 4148 4173 +25
Branches 103 106 +3
==========================================
+ Hits 3936 3963 +27
+ Misses 212 210 -2
Continue to review full report at Codecov.
|
|
@kailuowang @edmundnoble can you gentlemen review this? I think it should be ready. |
edmundnoble
approved these changes
Aug 17, 2017
LukaJCB
pushed a commit
to LukaJCB/cats
that referenced
this pull request
Sep 1, 2017
* Added more implementations of map2Eval I hit a case where I wanted laziness with map2Eval and realized in many cases where we could have it, we do not. There were all the cases I saw that we missed, which I hope our existing tests cover. * Add tests for map2 and map2Eval * remove incorrect instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a case where I wanted laziness with map2Eval and realized in many
cases where we could have it, we do not. There were all the cases I saw
that we missed, which I hope our existing tests cover.