Remove sbt-ghpages because it is pulled in by sbt-microsites #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbt-ghpages is a dependency of sbt-microsites and therefore does not need to be listed explicitly as plugin. We have the same situation with tut whose keys we are using in our `build.sbt` but do not explicitly list in `plugins.sbt`.
|
👍 |
Codecov Report
@@ Coverage Diff @@
## master #1852 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 241 241
Lines 4173 4173
Branches 106 106
=======================================
Hits 3963 3963
Misses 210 210Continue to review full report at Codecov.
|
peterneyens
approved these changes
Aug 26, 2017
LukaJCB
pushed a commit
to LukaJCB/cats
that referenced
this pull request
Sep 1, 2017
…el#1852) sbt-ghpages is a dependency of sbt-microsites and therefore does not need to be listed explicitly as plugin. We have the same situation with tut whose keys we are using in our `build.sbt` but do not explicitly list in `plugins.sbt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sbt-ghpages is a dependency of sbt-microsites and therefore does
not need to be listed explicitly as plugin. We have the same situation
with tut whose keys we are using in our
build.sbtbut do not explicitlylist in
plugins.sbt.