Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kernel laws consistent with core laws #1922

Merged
merged 21 commits into from
Oct 6, 2017
Merged

Make kernel laws consistent with core laws #1922

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
20806ee
Make GroupLaws consistent with cats-core
Sep 19, 2017
269f0e9
Make OrderLaws consistent with core
Sep 20, 2017
ea453b3
Port tests
Sep 20, 2017
6bebba6
Update lawtesting docs
Sep 21, 2017
b9b2264
Remove unused machinery
Sep 21, 2017
28b0b41
Remove duplication of IsEq
Sep 21, 2017
b1fb806
Cleanup
Sep 21, 2017
e50bf06
Add Serializable to LawTests
Sep 22, 2017
b57dc31
Rename to -LawTests
Sep 27, 2017
b6de9dd
Fix BoundedSemilattice parents
Sep 27, 2017
f81d7b2
Add id
Sep 27, 2017
5073a95
Fix lawtesting docs
Sep 28, 2017
8435559
Restructure order law tests
Sep 28, 2017
e9ee232
Merge branch 'master' into make-kernel-laws-consistent
Oct 3, 2017
c6ce594
Move IsEq
Oct 4, 2017
8c60716
Merge branch 'master' into make-kernel-laws-consistent
Oct 4, 2017
8dbbb81
Convert HashLaws to new setup
Oct 4, 2017
ca30cd4
Readd function0 hash test
Oct 4, 2017
08e1bcd
Add mima exception
Oct 4, 2017
1ca0ecd
Rename to ascending order
Oct 5, 2017
668c4e1
Merge branch 'master' into make-kernel-laws-consistent
Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kernel-laws/src/main/scala/cats/kernel/laws/discipline/HashTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ trait HashTests[A] extends EqLawTests[A] {
Some(eqv),
"hash compatibility" -> forAll(laws.hashCompatibility _),
"same as universal hash" -> forAll(laws.sameAsUniversalHash _),
"same as universal hash" -> forAll((x: A, y: A) => laws.sameAsScalaHashing(x, y, hashA))
"same as scala hashing" -> forAll((x: A, y: A) => laws.sameAsScalaHashing(x, y, hashA))
)

}
Expand Down
8 changes: 8 additions & 0 deletions tests/src/test/scala/cats/tests/FunctionTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package cats
package tests

import cats.arrow.{Choice, CommutativeArrow}
import cats.kernel.laws.HashLaws
import cats.kernel.laws.discipline.{SerializableTests, _}
import cats.laws.discipline._
import cats.laws.discipline.eq._
Expand Down Expand Up @@ -54,6 +55,13 @@ class FunctionTests extends CatsSuite {
checkAll("Function0[Grp]", GroupLawTests[Function0[Grp]].group)
checkAll("Function0[CGrp]", CommutativeGroupTests[Function0[CGrp]].commutativeGroup)

test("Function0[Hsh]") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why not just test the hash law? won't pass?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why not just test the full HashLaw? won't pass?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not the same as universal hash and not the same as scala.util.Hashing

forAll { (x: Function0[Hsh], y: Function0[Hsh]) =>
HashLaws[Function0[Hsh]].hashCompatibility(x, y)
}
}


// serialization tests for the various Function0-related instances
checkAll("Eq[() => Eqed]", SerializableTests.serializable(Eq[() => Eqed]))
checkAll("PartialOrder[() => POrd]", SerializableTests.serializable(PartialOrder[() => POrd]))
Expand Down