Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the right issue number of doom. #1956

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Mention the right issue number of doom. #1956

merged 1 commit into from
Oct 8, 2017

Conversation

hrhino
Copy link
Contributor

@hrhino hrhino commented Oct 8, 2017

I'm as much a fan of Rush as the next person, but 2712 should be a famous number in its own right.

Also, scala uses GitHub now.

I was intending on making a cooler first PR, but I skimmed the README while IntelliJ did what it does and now I can't un-notice this.

I'm as much a fan of Rush as the next person, but
2712 should be a famous number in its own right.

Also, scala uses GitHub now.
Copy link
Contributor

@adelbertc adelbertc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @hrhino ! All PRs are cool PRs :-) 👍 once Travis gives the green light (not sure why it wouldn't..)

@codecov-io
Copy link

codecov-io commented Oct 8, 2017

Codecov Report

Merging #1956 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1956   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files         273      273           
  Lines        4535     4535           
  Branches      117      116    -1     
=======================================
  Hits         4360     4360           
  Misses        175      175

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29faf62...41adf38. Read the comment docs.

@adelbertc
Copy link
Contributor

Doc change, merging with 1 👍

@adelbertc adelbertc merged commit b84015a into typelevel:master Oct 8, 2017
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants