-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few type classes to generated tuple instances (continued) #1967
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1967 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 273 273
Lines 4541 4541
Branches 119 110 -9
=======================================
Hits 4363 4363
Misses 178 178 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested that the priority is correct, perhaps in the REPL? Otherwise 👍.
Yes @edmundnoble I tested in REPL . There is a separated issue for adding tests for generated coded #1968. We'll tackle the tests there. |
This is to finish up #1527 by
a) reorder the instance according to priority
b) added Mima rule exceptions, these changes were approved by @johnynek