Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few type classes to generated tuple instances (continued) #1967

Merged
merged 6 commits into from
Oct 18, 2017

Conversation

kailuowang
Copy link
Contributor

This is to finish up #1527 by
a) reorder the instance according to priority
b) added Mima rule exceptions, these changes were approved by @johnynek

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #1967 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1967   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         273      273           
  Lines        4541     4541           
  Branches      119      110    -9     
=======================================
  Hits         4363     4363           
  Misses        178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c121f4f...e28baf5. Read the comment docs.

Copy link
Contributor

@edmundnoble edmundnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that the priority is correct, perhaps in the REPL? Otherwise 👍.

@kailuowang
Copy link
Contributor Author

Yes @edmundnoble I tested in REPL . There is a separated issue for adding tests for generated coded #1968. We'll tackle the tests there.

@kailuowang kailuowang merged commit 2a49669 into typelevel:master Oct 18, 2017
@kailuowang kailuowang deleted the edmundnoble-patch-1 branch October 18, 2017 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants