-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change forEffect/followedBy to productL/productR #2083
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e54119d
Change forEffect/followedBy to apL/apR. Depricated old methods, added…
Jacoby6000 40bc6d3
Fix compatibility problem I introduced when I moved *> and <*
Jacoby6000 3ae37e8
updated parFollwedBy/parForEffect/followedByEval/forEffectEval to use…
Jacoby6000 265ffca
Create scalafix rules for PR 2083
Jacoby6000 091fd3f
Minor fixes and adjustments to remain consistent with the existing api
Jacoby6000 6848b70
Merge branch '#1983' into #2083-scalafix
Jacoby6000 171538b
Un-comment the parApL/R tests.
Jacoby6000 5f6a0bb
Remove scalafix tests for apL/apR
Jacoby6000 5943875
added Mima exceptions
kailuowang afe5632
Merge branch 'master' into #1983
kailuowang b9112c1
Update FAQ symbols
f4b98ee
Merge branch 'master' into #1983
37cd5cf
Merge branch 'master' into #1983
eb7edd9
Update deprecations, method name
Jacoby6000 6dca0cc
Update doc with product(L/R)
Jacoby6000 1ec6706
Update mima for product(L/R)
Jacoby6000 278b36e
Remove accidental whitespace
Jacoby6000 0153f3d
Undo changes I made to map2/product
Jacoby6000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, why is it that this new syntax is needed? Does simulacrum not generate syntax for deprecated methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generate as deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simulacrum does generate the deprecated methods, which makes scalac complain since it references the original deprecated method.