Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CommutativeMonoid for Map #2098

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Add a CommutativeMonoid for Map #2098

merged 3 commits into from
Dec 14, 2017

Commits on Dec 12, 2017

  1. Add a CommutativeMonoid for Map 

    Since we already have a `Monoid` instance for `Map`, it seems natural to
have a `CommutativeMonoid` when the value type has a commutative
semigroup.

Note: Unfortunately, I believe that this is a binary-incompatible change in cats kernel. cc @johnynek
    @ceedubs
    ceedubs committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    4599c32 View commit details
    Browse the repository at this point in the history

  2. Add mima exception for Map commutative monoid

    @ceedubs
    ceedubs committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    9b9dbcc View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2017

  1. Use non-commutative monoid for MonoidTests of Map

    LukaJCB authored Dec 13, 2017
    Configuration menu
    Copy the full SHA
    fa99829 View commit details
    Browse the repository at this point in the history