Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommutativeMonad and CommutativeFlatMap instances for Tuple2 #2099

Merged
merged 2 commits into from
Dec 13, 2017

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Dec 12, 2017

I think that these are fairly straightforward/legitimate. Speak up if
that's not true :)

I think that these are fairly straightforward/legitimate. Speak up if
that's not true :)
@ceedubs
Copy link
Contributor Author

ceedubs commented Dec 12, 2017

It should be possible to do the same sort of thing for Writer, but Writer is a little different in that there are a couple of different FlatMap instances defined in a hierarchy. I don't have the time to look into it right at the moment, but someone else can feel free.

johnynek
johnynek previously approved these changes Dec 12, 2017
@ceedubs
Copy link
Contributor Author

ceedubs commented Dec 13, 2017

I need to add some Mima exceptions. I'll do that now.

@codecov-io
Copy link

codecov-io commented Dec 13, 2017

Codecov Report

Merging #2099 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2099      +/-   ##
==========================================
+ Coverage   94.65%   94.75%   +0.09%     
==========================================
  Files         322      322              
  Lines        5449     5454       +5     
  Branches      215      214       -1     
==========================================
+ Hits         5158     5168      +10     
+ Misses        291      286       -5
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/tuple.scala 100% <100%> (ø) ⬆️
...ws/src/main/scala/cats/laws/DistributiveLaws.scala 100% <0%> (ø) ⬆️
...scala/cats/laws/discipline/DistributiveTests.scala 100% <0%> (ø) ⬆️
.../main/scala/cats/laws/CommutativeFlatMapLaws.scala 100% <0%> (+33.33%) ⬆️
...cats/laws/discipline/CommutativeFlatMapTests.scala 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91e9bb...1443365. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup these are great, thanks! :)

@LukaJCB LukaJCB added this to the 1.0.0 milestone Dec 13, 2017
@kailuowang kailuowang merged commit e27266a into typelevel:master Dec 13, 2017
@ceedubs ceedubs deleted the tuple2-commutative-monad branch December 13, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants