Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoflatMap Instance for Applicative #2112

Merged
merged 2 commits into from
Dec 16, 2017

Conversation

ChristopherDavenport
Copy link
Member

Adds CoflatMap instance for Applicative. Discovered this today looking at extension for libraries using tests and believe this to be lawful as far as I can tell from an initial inspection.

LukaJCB
LukaJCB previously approved these changes Dec 15, 2017
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks very much! :)

@codecov-io
Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #2112 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
+ Coverage   94.58%   94.59%   +<.01%     
==========================================
  Files         325      325              
  Lines        5507     5510       +3     
  Branches      220      223       +3     
==========================================
+ Hits         5209     5212       +3     
  Misses        298      298
Impacted Files Coverage Δ
core/src/main/scala/cats/Applicative.scala 90% <100%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8120890...36b428a. Read the comment docs.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LukaJCB LukaJCB merged commit 32eaac6 into typelevel:master Dec 16, 2017
@ChristopherDavenport ChristopherDavenport deleted the coflatMapApplicative branch December 16, 2017 12:57
@kailuowang kailuowang added this to the 1.0.0-RC2 milestone Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants