-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NonEmptyMap #2141
Merged
Merged
Add NonEmptyMap #2141
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bab788b
Add NonEmptyMap
31ecdac
Add more docs
8a2b024
Move to newtype encoding
aa4ca5e
Rename NonEmptyMap#get to not conflict with Reducible.get
7525ca8
Fix 2.11 and 2.10 compilation
f116d96
Fix 2.10 as well
387dec1
Remove semilattice instance
5811a50
Extra tests
d3d1635
Add groupByNem to NonEmptyList
cf586b3
Hide more newtype machinery
e764237
Move newtype to its own file
f231d68
Address feedback
0e07055
Remove context bounds
22c471c
Make newtype private
e63f01f
Merge branch 'master' into add-nonemptymap
60327b1
keys now returns a NonEmptySet
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you changed it to semilattice here but not the law testing? I am not sure if
Map
combine is commutative.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, right, yeah that was dumb, I'll check that one later :)