Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update travis cache settings #2158

Merged
merged 1 commit into from
Jan 23, 2018
Merged

update travis cache settings #2158

merged 1 commit into from
Jan 23, 2018

Conversation

kailuowang
Copy link
Contributor

mostly copied from circe

@kailuowang
update travis cache settings
784895f 
mostly copied from circe
@codecov-io
Copy link

codecov-io commented Jan 23, 2018 •
edited
Loading

Codecov Report

Merging #2158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2158   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files         328      328           
  Lines        5538     5538           
  Branches      199      199           
=======================================
  Hits         5243     5243           
  Misses        295      295

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32bcfc5...784895f. Read the comment docs.

@johnynek
Copy link
Contributor

👍

seems marginally faster, or at least not slower, and it is also simpler.

LukaJCB
LukaJCB approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kailuowang kailuowang merged commit dbac00d into master Jan 23, 2018
@kailuowang kailuowang deleted the kailuowang-patch-2 branch January 23, 2018 18:15
@kailuowang kailuowang added this to the 1.1 milestone Jan 31, 2018
@Gryfit Gryfit mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@johnynek johnynek johnynek approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kailuowang @codecov-io @johnynek @LukaJCB