Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to PartialFunction.apply, deprecated in 2.12.5 #2188

Merged
merged 1 commit into from Mar 12, 2018
Merged

Remove calls to PartialFunction.apply, deprecated in 2.12.5 #2188

merged 1 commit into from Mar 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 11, 2018

PartialFunction.apply is deprecated in 2.12.5, removed in 2.13.0. So this PR is advance work for the 2.13 build. Error message in 2.13.0-M3 build:

method apply in object PartialFunction is deprecated (since 2.12.5): For converting an ordinary function f to a partial function pf, use val pf: PartialFunction[A, B] = { case x => f(x) }. For creating a new PartialFunction, use an explicit type annotation instead, like in val pf: PartialFunction[Int, String] = { case 1 => "one" }.

Required for #2173

@codecov-io
Copy link

codecov-io commented Mar 11, 2018

Codecov Report

Merging #2188 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         330      330           
  Lines        5568     5568           
  Branches      201      203    +2     
=======================================
  Hits         5276     5276           
  Misses        292      292
Impacted Files Coverage Δ
laws/src/main/scala/cats/laws/MonadErrorLaws.scala 100% <100%> (ø) ⬆️
...rc/main/scala/cats/laws/ApplicativeErrorLaws.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39b856...573cf5f. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang merged commit 6b01eda into typelevel:master Mar 12, 2018
@kailuowang kailuowang added this to the 1.1 milestone Mar 12, 2018
@kailuowang kailuowang added the bug label Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants