Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CONTRIBUTING docs #2234

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Fix CONTRIBUTING docs #2234

merged 1 commit into from
Sep 6, 2018

Conversation

asakaev
Copy link
Contributor

@asakaev asakaev commented Apr 19, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #2234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2234   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         357      357           
  Lines        6516     6516           
  Branches      288      288           
=======================================
  Hits         6216     6216           
  Misses        300      300

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f92c85...0eca253. Read the comment docs.

@asakaev asakaev closed this Apr 20, 2018
@asakaev asakaev deleted the docs branch April 20, 2018 23:37
@asakaev asakaev restored the docs branch April 20, 2018 23:38
@asakaev asakaev reopened this Apr 20, 2018
CONTRIBUTING.md Outdated
@@ -122,7 +122,7 @@ builds:

### Write code

[See guidelines](/cats/guidelines.html).
[See guidelines](/docs/src/main/tut/guidelines.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this change works if someone is browsing this md file on GitHub, but I think that it will break the link on the actual website. I'm not sure what's best here -- have we solved this problem for other links?

@kailuowang kailuowang modified the milestone: 1.2 May 30, 2018
@asakaev asakaev changed the title Fix contributing docs Fix CONTRIBUTING docs Sep 4, 2018
@kailuowang kailuowang merged commit b6903be into typelevel:master Sep 6, 2018
@kailuowang kailuowang added this to the 1.4 milestone Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants