Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .toOptionT to option syntax #2253

Merged
merged 1 commit into from
May 19, 2018
Merged

Conversation

marcodippy
Copy link
Contributor

just a postfix version of OptionT.fromOption

@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

Merging #2253 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
+ Coverage   94.96%   94.96%   +<.01%     
==========================================
  Files         333      333              
  Lines        5797     5798       +1     
  Branches      221      216       -5     
==========================================
+ Hits         5505     5506       +1     
  Misses        292      292
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/option.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 680a517...3a87de9. Read the comment docs.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a toEitherT on Either, so it seems consistent to me to have this.

@LukaJCB LukaJCB merged commit 21c3039 into typelevel:master May 19, 2018
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants