Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala, sbt, and sbt plugins #2260

Merged
merged 3 commits into from
May 19, 2018

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented May 18, 2018

No description provided.

LukaJCB
LukaJCB previously approved these changes May 18, 2018
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ceedubs
Copy link
Contributor

ceedubs commented May 18, 2018

The build is failing with [error] (bench / Compile / compileIncremental) scala.reflect.internal.MissingRequirementError: object java.lang.Object in compiler mirror not found.

I feel like java.lang.Object is something that should probably be there. 🤔

@LukaJCB
Copy link
Member

LukaJCB commented May 19, 2018

@ceedubs That seems to be an issue in every single build for 2.11, not specific to this PR. No clue what's going on there 😄

@fthomas
Copy link
Member Author

fthomas commented May 19, 2018

The first error seems to be

[error] error while loading <root>, Error accessing /home/travis/.coursier/cache/v1/https/repo1.maven.org/maven2/org/scalaz/scalaz-core_2.11/7.2.21/scalaz-core_2.11-7.2.21.jar

I tried deleting the build cache but this had no effect. I'll investigate further.

@codecov-io
Copy link

codecov-io commented May 19, 2018

Codecov Report

Merging #2260 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2260     +/-   ##
=========================================
+ Coverage   94.66%   94.96%   +0.3%     
=========================================
  Files         333      333             
  Lines        5787     5799     +12     
  Branches      216      218      +2     
=========================================
+ Hits         5478     5507     +29     
+ Misses        309      292     -17
Impacted Files Coverage Δ
laws/src/main/scala/cats/laws/MonadLaws.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/syntax/option.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Ior.scala 98.48% <0%> (+0.01%) ⬆️
core/src/main/scala/cats/data/Kleisli.scala 96.93% <0%> (+0.03%) ⬆️
core/src/main/scala/cats/Eval.scala 98.75% <0%> (+0.04%) ⬆️
core/src/main/scala/cats/data/IorT.scala 97.76% <0%> (+0.05%) ⬆️
core/src/main/scala/cats/syntax/either.scala 99.16% <0%> (+14.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0944cfe...af05335. Read the comment docs.

@fthomas
Copy link
Member Author

fthomas commented May 19, 2018

Updating Scalaz to 7.2.23 fixed the problem on 2.11 - but don't ask me why.

@kailuowang kailuowang merged commit 88e25ee into typelevel:master May 19, 2018
@fthomas fthomas deleted the update/scala-sbt-and-plugins branch May 30, 2018 05:29
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants