Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bin compat versions to 1.0.0 and 1.1.0 #2264

Merged
merged 2 commits into from
May 21, 2018
Merged

Conversation

kailuowang
Copy link
Contributor

somehow I missed that last release

@tpolecat
Copy link
Member

It should stay at 1.0 shouldn't it? We want to guarantee compatibility all the way back.

@kailuowang
Copy link
Contributor Author

but that won't capture bin compat break between 1.1.0 and 1.2.0, e.g. if 1.1.0 introduced a new trait, 1.2.0 could add a method to it while still bin compat with 1.0.

@ChristopherDavenport
Copy link
Member

@kailuowang I believe MiMa allows multiple versions to be set. Such that mimaPreviousArtifacts points at both 1.1.0 and 1.0.0

@kailuowang
Copy link
Contributor Author

@chir thanks for the tip , I'll update that

@kailuowang kailuowang changed the title update bin compat version to 1.1.0 update bin compat versions to 1.0.0 and 1.1.0 May 21, 2018
@tpolecat
Copy link
Member

I remain confused. What's the value in checking against 1.1.0?

@johnynek
Copy link
Contributor

@tpolecat we could actually be compatible with 1.0.0 but not compatible with 1.1.0. Imagine we remove some of the compatible methods we added in 1.1.0.

We want to be compatible with all previous versions in 1.x.y, and unless mima has bugs (which of course, it does because it is software), checking only the previous should be safe. But we could help detect bugs in mima by also doing the full transitive closure in our CI. If it gets too slow, we can only do a subset of the previous releases.

@tpolecat
Copy link
Member

Aha, gotcha. Yep 👍

@tpolecat
Copy link
Member

It would be cool if sbt-release maintained this list the same way it maintains version.

@codecov-io
Copy link

codecov-io commented May 21, 2018

Codecov Report

Merging #2264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2264   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         333      333           
  Lines        5799     5799           
  Branches      218      218           
=======================================
  Hits         5507     5507           
  Misses        292      292

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e25ee...41d3dbc. Read the comment docs.

@kailuowang kailuowang merged commit 9af5186 into master May 21, 2018
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
@kailuowang kailuowang deleted the kailuowang-patch-3 branch June 19, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants