-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bin compat versions to 1.0.0 and 1.1.0 #2264
Conversation
It should stay at 1.0 shouldn't it? We want to guarantee compatibility all the way back. |
but that won't capture bin compat break between 1.1.0 and 1.2.0, e.g. if 1.1.0 introduced a new trait, 1.2.0 could add a method to it while still bin compat with 1.0. |
@kailuowang I believe MiMa allows multiple versions to be set. Such that mimaPreviousArtifacts points at both |
@chir thanks for the tip , I'll update that |
I remain confused. What's the value in checking against 1.1.0? |
@tpolecat we could actually be compatible with We want to be compatible with all previous versions in 1.x.y, and unless mima has bugs (which of course, it does because it is software), checking only the previous should be safe. But we could help detect bugs in mima by also doing the full transitive closure in our CI. If it gets too slow, we can only do a subset of the previous releases. |
Aha, gotcha. Yep 👍 |
It would be cool if sbt-release maintained this list the same way it maintains |
Codecov Report
@@ Coverage Diff @@
## master #2264 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 333 333
Lines 5799 5799
Branches 218 218
=======================================
Hits 5507 5507
Misses 292 292 Continue to review full report at Codecov.
|
somehow I missed that last release