Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add choice syntax #2315

Merged
merged 2 commits into from
Jul 9, 2018
Merged

Add choice syntax #2315

merged 2 commits into from
Jul 9, 2018

Conversation

catostrophe
Copy link
Contributor

Choice doesn't have a separate syntax object in cats.syntax package and its syntax (choice, |||) is not accessible via import cats.implicits._

@codecov-io
Copy link

codecov-io commented Jul 7, 2018

Codecov Report

Merging #2315 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2315      +/-   ##
==========================================
+ Coverage   94.73%   95.04%   +0.31%     
==========================================
  Files         338      338              
  Lines        5868     5878      +10     
  Branches      213      207       -6     
==========================================
+ Hits         5559     5587      +28     
+ Misses        309      291      -18
Impacted Files Coverage Δ
core/src/main/scala/cats/arrow/Choice.scala 100% <ø> (+50%) ⬆️
laws/src/main/scala/cats/laws/ChoiceLaws.scala 100% <100%> (ø) ⬆️
laws/src/main/scala/cats/laws/MonadLaws.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Ior.scala 98.48% <0%> (+0.01%) ⬆️
core/src/main/scala/cats/Eval.scala 98.75% <0%> (+0.04%) ⬆️
core/src/main/scala/cats/data/IorT.scala 97.76% <0%> (+0.05%) ⬆️
core/src/main/scala/cats/syntax/either.scala 99.16% <0%> (+14.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ef0e9...e44983f. Read the comment docs.

@catostrophe catostrophe closed this Jul 7, 2018
@catostrophe catostrophe reopened this Jul 7, 2018
@kailuowang
Copy link
Contributor

Thanks @catostrophe

@kailuowang kailuowang added this to the 1.2 milestone Jul 9, 2018
@kailuowang kailuowang requested a review from LukaJCB July 9, 2018 14:29
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kailuowang kailuowang merged commit a298890 into typelevel:master Jul 9, 2018
@catostrophe catostrophe deleted the choice-syntax branch August 5, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants