Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sbt-doctest for Defer example #2344

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Use sbt-doctest for Defer example #2344

merged 1 commit into from
Jul 30, 2018

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Jul 27, 2018

We might as well use sbt-doctest to ensure that this example continues
to compile.

@ceedubs
Use sbt-doctest for Defer example
950b3af 
We might as well use sbt-doctest to ensure that this example continues
to compile.
@ceedubs ceedubs requested a review from johnynek July 27, 2018 14:43
kailuowang
kailuowang approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov-io
Copy link

codecov-io commented Jul 27, 2018 •
edited
Loading

Codecov Report

Merging #2344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2344   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         345      345           
  Lines        5991     5991           
  Branches      217      219    +2     
=======================================
  Hits         5697     5697           
  Misses        294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c4b7a...950b3af. Read the comment docs.

@ceedubs ceedubs merged commit 7573e7a into typelevel:master Jul 30, 2018
@ceedubs ceedubs deleted the defer-doctest branch July 30, 2018 14:21
@kailuowang kailuowang added this to the 1.3 milestone Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

@johnynek johnynek johnynek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ceedubs @codecov-io @johnynek @kailuowang @LukaJCB @ChristopherDavenport