-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make kittens officially a Cats module (still separate repo) #2361
Conversation
I had a discussion with @milessabin see (typelevel/kittens#96). We think that making kittens an official cats module (still in its own separate repo) would be a good idea. @milessabin moved it to under github typelevel. I'm proposing this to the Cats community through this PR.
I'm a bit hesitant on this. Kittens depends on Shapeless, right? Here are some concerns that I would have:
I'm happy to see kittens in the |
@ceedubs not a module inside cats repo, it's still in its own repo with its own release cycle just like the other 3 "outside" modules cats-mtl, cats-effect and mouse. |
Does "official cats module" mean anything other than appearing on this bullet list? This is fine, it's just probably worth clarifying. |
@tpolecat that's mostly it. Although I'd say that cats modules get a commitment from Cats maintainers to help to maintain them. |
@kailuowang ah okay. I understand. I'm all for this then. I do have a concern about kittens derivation that has prevented me from using it and I've been meaning to look for a discussion of, but I'll pursue that separately. |
Regarding commitment to maintain, I'd happily help out, but I fear my shapeless skills really aren't up to par. I do think |
Codecov Report
@@ Coverage Diff @@
## master #2361 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 349 349
Lines 5993 5993
Branches 223 225 +2
=======================================
Hits 5694 5694
Misses 299 299 Continue to review full report at Codecov.
|
seems that we have enough approval. It's official! |
I had a discussion with @milessabin see (typelevel/kittens#96). We think that making kittens an official cats module (still in its own separate repo) would be a good idea. @milessabin moved it to under github typelevel. I'm proposing this to the Cats community through this PR.
Update: I updated the title to further clarify the intention.