Removed not used sbt-scala-native plugin and fixed importing the project into intellij #2382
Conversation
|
Why do you say it is a dead line? Looks to me like support for scala native in the kernel module. |
LukaszMarchewka
force-pushed
the
fixed_idea
branch
from
f71b31c
to
29e0815
Compare
|
Wow....this is work in progress for native, only recently added. More work is in the pipeline with new release of of sbt-crossproject like 2 days ago |
project/plugins.sbt
Outdated
| @@ -16,4 +16,3 @@ addSbtPlugin("org.tpolecat" % "tut-plugin" % "0.6.6") | |||
| addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "0.5.0") | |||
| addSbtPlugin("org.portable-scala" % "sbt-scala-native-crossproject" % "0.5.0") | |||
| addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.24") | |||
| addSbtPlugin("org.scala-native" % "sbt-scala-native" % "0.3.7") | |||
build.sbt
Outdated
| lazy val kernelNative = kernel.native.settings( | ||
| scalaVersion := "2.11.12", | ||
| crossScalaVersions := Seq("2.11.12") | ||
| ) |
There was a problem hiding this comment.
These settings (or any, for that matter) should not go directly on the internal project. Instead:
- Add to a
lazy val commonNativeSettings, as per js and jvm - then add the settings to the project using
.nativeSettings(commonNativeSettings)
Apologies for any typos, code not tested ...
Ideally, we need dwijnand/sbt-travisci#11 here
|
I have a PR for #2364 waiting to go. We could expedite this by merging as-is, and my new PR can tweak afterwards. |
…ect into intellij
LukaszMarchewka
force-pushed
the
fixed_idea
branch
from
29e0815
to
c51c693
Compare
Codecov Report
@@ Coverage Diff @@
## master #2382 +/- ##
======================================
Coverage 95.2% 95.2%
======================================
Files 361 361
Lines 6584 6584
Branches 282 282
======================================
Hits 6268 6268
Misses 316 316Continue to review full report at Codecov.
|
|
@BennyHill sorry for delay, I wasn't able to update this faster. I have applied all your suggestions. |
|
@LukaszMarchewka Thanks! You'll see in next PR for composite projects that the lines lazy val kernelJVM = kernel.jvm
lazy val kernelJS = kernel.js
lazy val kernelNative = kernel.nativeand similar will all disappear...so I'm not just being picky here 😄 |
|
@kailuowang Should we merge this for now, as it seems to resolve a common blocker for people wanting to contribute to cats? |
|
@LukaJCB @kailuowang any progress? I actually know about some potential contributors that are blocked by this :P |
kailuowang
dismissed stale reviews from easel, LukaJCB, and themself
via
1a8bd84
I have had a problem during importing the project into intellij (version 2018.2) . Intellij tried to download
scala-nativefor scala 2.12. I have solved the problem by:scala-native-plugin