add append method to NEL #2416
Merged
add append method to NEL #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's add a quick test for this? Doctest, maybe? :) |
Codecov Report
@@ Coverage Diff @@
## master #2416 +/- ##
==========================================
+ Coverage 94.88% 94.88% +<.01%
==========================================
Files 350 350
Lines 6258 6261 +3
Branches 284 278 -6
==========================================
+ Hits 5938 5941 +3
Misses 320 320
Continue to review full report at Codecov.
|
martin-g
reviewed
Aug 16, 2018
| /** | ||
| * Alias for append | ||
| */ | ||
| def :+[AA >: A](a: AA): NonEmptyList[AA] = |
There was a problem hiding this comment.
sure but I would prefer we do that in a separate PR as there is no final method in NEL yet
|
@LukaJCB good idea, done |
kailuowang
approved these changes
Aug 16, 2018
catostrophe
pushed a commit
to catostrophe/cats
that referenced
this pull request
Sep 15, 2018
* add append method to NEL * add doctest for :+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.