Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for FlatMap and Bifunctor #2459

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

asoltysik
Copy link
Contributor

No description provided.

@@ -0,0 +1,52 @@
---
layout: docs
title: "Functor"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Bifunctor I assume? :)

Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuple2 is very similar to Map, maybe mention that one first in FlatMap and mention Map as a similar case.

@codecov-io
Copy link

Codecov Report

Merging #2459 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2459   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         357      357           
  Lines        6516     6516           
  Branches      288      288           
=======================================
  Hits         6216     6216           
  Misses        300      300

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f129c6...5b46d50. Read the comment docs.

@kailuowang
Copy link
Contributor

Tuple2 is a good example to add that as well. I propose we merge and add that in a separate PR.

@kailuowang kailuowang merged commit 8f1aafe into typelevel:master Sep 25, 2018
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants