Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align type parameter of smart constructor with Validated (#2525) #2527

Merged
merged 1 commit into from
Sep 24, 2018
Merged

align type parameter of smart constructor with Validated (#2525) #2527

merged 1 commit into from
Sep 24, 2018

Conversation

TomTriple
Copy link
Contributor

No description provided.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! :)

@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #2527 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2527   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files         358      358           
  Lines        6533     6533           
  Branches      273      273           
=======================================
  Hits         6228     6228           
  Misses        305      305
Impacted Files Coverage Δ
core/src/main/scala/cats/data/Validated.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a6c91...ce8d4fa. Read the comment docs.

@LukaJCB LukaJCB merged commit 2388287 into typelevel:master Sep 24, 2018
@TomTriple TomTriple deleted the smart-constructors-and-type-parameters-2525 branch September 24, 2018 19:29
@kailuowang kailuowang added this to the 1.5 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants