-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApplicativeError.redeem and MonadError.redeemWith #2560
Conversation
682f318
to
3187dcf
Compare
Codecov Report
@@ Coverage Diff @@
## master #2560 +/- ##
==========================================
- Coverage 95.21% 95.18% -0.03%
==========================================
Files 361 361
Lines 6598 6600 +2
Branches 280 276 -4
==========================================
Hits 6282 6282
- Misses 316 318 +2
Continue to review full report at Codecov.
|
I might've missed something. Is this a shortcut for |
@kailuowang Well it's supposed to be in the type class but because of 2.11 bin incompat it's juts in the ops. |
Thanks, that clarified the intention for me, I think. The issue is that if we can't add it to type class then we can't have instances to override it, then there isn't much point of adding it before 2.0 with which we shall be able to add it to type class without breaking BC, right? |
@kailuowang It probably make sense. |
yeah for cases like this , we can add it to the type class, let the mima test fail but schedule it to milesstone 2.0. |
This PR seems to be doing a very similar thing to @alexandru PR here #2237. |
@diesalbla Thanks I'm closing this one |
No description provided.