Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplicativeError.redeem and MonadError.redeemWith #2560

Closed
wants to merge 1 commit into from

Conversation

joan38
Copy link
Contributor

@joan38 joan38 commented Oct 15, 2018

No description provided.

@joan38 joan38 changed the title Add ApplicativeError.redeem and ApplicativeError.redeemWith Add ApplicativeError.redeem and MonadError.redeemWith Oct 15, 2018
@joan38 joan38 force-pushed the redeem branch 2 times, most recently from 682f318 to 3187dcf Compare October 17, 2018 11:47
@codecov-io
Copy link

codecov-io commented Oct 17, 2018

Codecov Report

Merging #2560 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
- Coverage   95.21%   95.18%   -0.03%     
==========================================
  Files         361      361              
  Lines        6598     6600       +2     
  Branches      280      276       -4     
==========================================
  Hits         6282     6282              
- Misses        316      318       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/monadError.scala 88.88% <0%> (-11.12%) ⬇️
.../src/main/scala/cats/syntax/applicativeError.scala 93.75% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191fae4...682f318. Read the comment docs.

@kailuowang
Copy link
Contributor

I might've missed something. Is this a shortcut for fa.map(f).handleError(ef)?

@joan38
Copy link
Contributor Author

joan38 commented Oct 17, 2018

@kailuowang Well it's supposed to be in the type class but because of 2.11 bin incompat it's juts in the ops.
This is to match the IO.redeem.

@kailuowang
Copy link
Contributor

kailuowang commented Oct 17, 2018

Thanks, that clarified the intention for me, I think. The issue is that if we can't add it to type class then we can't have instances to override it, then there isn't much point of adding it before 2.0 with which we shall be able to add it to type class without breaking BC, right?

@joan38
Copy link
Contributor Author

joan38 commented Oct 17, 2018

@kailuowang It probably make sense.
How do we handle stuff that will go in 2.0? Do we keep breaking PRs like this one open?

@kailuowang
Copy link
Contributor

yeah for cases like this , we can add it to the type class, let the mima test fail but schedule it to milesstone 2.0.

@diesalbla
Copy link
Contributor

This PR seems to be doing a very similar thing to @alexandru PR here #2237.

@joan38
Copy link
Contributor Author

joan38 commented Oct 19, 2018

@diesalbla Thanks I'm closing this one

@joan38 joan38 closed this Oct 19, 2018
@joan38 joan38 deleted the redeem branch October 19, 2018 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants