Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2611 - MonadError syntax for OptionT uses incorrect instance #2615

Merged
merged 5 commits into from
Nov 19, 2018
Merged

2611 - MonadError syntax for OptionT uses incorrect instance #2615

merged 5 commits into from
Nov 19, 2018

Conversation

barambani
Copy link
Contributor

Fixes #2611

@kailuowang
Copy link
Contributor

This is awesome! Thanks so much!

@kailuowang kailuowang changed the base branch from master to 1.5.x November 16, 2018 01:07
@kailuowang kailuowang modified the milestones: 1.5, 1.5-RC0, 1.5.0-RC1 Nov 16, 2018
@kailuowang kailuowang changed the base branch from 1.5.x to master November 16, 2018 01:19
@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #2615 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2615      +/-   ##
==========================================
- Coverage   95.14%   95.11%   -0.03%     
==========================================
  Files         363      363              
  Lines        6695     6697       +2     
  Branches      291      307      +16     
==========================================
  Hits         6370     6370              
- Misses        325      327       +2
Impacted Files Coverage Δ
...patTest/src/main/scala/catsBC/MimaExceptions.scala 0% <0%> (ø) ⬆️
core/src/main/scala/cats/data/OptionT.scala 96.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a7cfc...2904a16. Read the comment docs.

kailuowang
kailuowang previously approved these changes Nov 16, 2018
kailuowang
kailuowang previously approved these changes Nov 16, 2018
LukaJCB
LukaJCB previously approved these changes Nov 17, 2018
@kailuowang
Copy link
Contributor

My merge using GitHub might broke the format, would you mind run sbt fmt?

@barambani barambani dismissed stale reviews from LukaJCB and kailuowang via d5bc2e9 November 17, 2018 18:13
kailuowang
kailuowang previously approved these changes Nov 18, 2018
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang merged commit 4331f64 into typelevel:master Nov 19, 2018
@barambani barambani deleted the issue-2611 branch November 19, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants