Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change prePR to run BC test on Scala 2.11 #2659

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

kailuowang
Copy link
Contributor

Just realized that currently prePR is testing BC on 2.12 which probably won't catch the majority of the BC breaking changes.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Dec 4, 2018

Codecov Report

Merging #2659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2659   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         363      363           
  Lines        6704     6704           
  Branches      305      289   -16     
=======================================
  Hits         6377     6377           
  Misses        327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72582ad...cc59293. Read the comment docs.

@LukaJCB
Copy link
Member

LukaJCB commented Dec 4, 2018

Going to merge, since this is such a tiny change that doesn't affect the actual code :)

@LukaJCB LukaJCB merged commit d30ef95 into master Dec 4, 2018
@kailuowang kailuowang added this to the 1.6 milestone Jan 8, 2019
@kailuowang kailuowang deleted the kailuowang-patch-1 branch February 15, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants