Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fix #2665

Merged
merged 1 commit into from
Dec 7, 2018
Merged

minor fix #2665

merged 1 commit into from
Dec 7, 2018

Conversation

kailuowang
Copy link
Contributor

@kailuowang kailuowang commented Dec 6, 2018 •
edited
Loading

No description provided.

@LukaJCB
Copy link
Member

LukaJCB commented Dec 6, 2018

How come this compiled? 🤔

@kailuowang
Copy link
Contributor Author

it's legitimate import right?

@kailuowang
Copy link
Contributor Author

sorry I wasn't clear. this import cats.implicits._ is redundant because it's already imported in previous blocks. However for doc purpose, I think we might still want to keep it.

@LukaJCB
Copy link
Member

LukaJCB commented Dec 6, 2018

Sounds good to me :)

calvinbrown085
calvinbrown085 approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@calvinbrown085 calvinbrown085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! @kailuowang

@ceedubs ceedubs merged commit f8324d4 into master Dec 7, 2018
@LukaJCB LukaJCB deleted the kailuowang-patch-2 branch December 7, 2018 14:44
@kailuowang kailuowang added this to the 1.6 milestone Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@calvinbrown085 calvinbrown085 calvinbrown085 approved these changes

@ceedubs ceedubs ceedubs approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.6.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@kailuowang @LukaJCB @ceedubs @calvinbrown085