Add IndexedState alias (#2686) #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailuowang
reviewed
Jan 10, 2019
| @@ -43,6 +43,9 @@ package object data { | |||
| def tell[L](l: L): Writer[L, Unit] = WriterT.tell(l) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Would you mind adding a doctest for the IndexedStateFunctions.apply here?
There was a problem hiding this comment.
Sure! Please see b858c14
Codecov Report
@@ Coverage Diff @@
## master #2693 +/- ##
=========================================
Coverage ? 95.15%
=========================================
Files ? 365
Lines ? 6770
Branches ? 296
=========================================
Hits ? 6442
Misses ? 328
Partials ? 0
Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Jan 10, 2019
kailuowang
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Cats!
This is a kind reminder to run
sbt prePRand commit the changed files, if any, before submitting.