-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TraverseFilter
instance for Set
to alleycats
#2726
Conversation
bb26bfb
to
5e5147b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
- Coverage 95.13% 94.88% -0.25%
==========================================
Files 365 365
Lines 6799 6780 -19
Branches 296 290 -6
==========================================
- Hits 6468 6433 -35
- Misses 331 347 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a bunch Diogo! 👍
@LukaJCB Thanks! :) |
Good call, I think it's fine to add it to this PR if you like :) |
@LukaJCB Apologies for the delay, it's done now :) I just reused the code from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, but this looks very good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome. Thanks very much!
No description provided.