Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TraverseFilter instance for Set to alleycats #2726

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

dcastro
Copy link
Contributor

@dcastro dcastro commented Feb 5, 2019

No description provided.

@LukaJCB LukaJCB self-requested a review February 5, 2019 13:30
@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #2726 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2726      +/-   ##
==========================================
- Coverage   95.13%   94.88%   -0.25%     
==========================================
  Files         365      365              
  Lines        6799     6780      -19     
  Branches      296      290       -6     
==========================================
- Hits         6468     6433      -35     
- Misses        331      347      +16
Impacted Files Coverage Δ
...eycats-core/src/main/scala/alleycats/std/set.scala 100% <100%> (ø) ⬆️
testkit/src/main/scala/cats/tests/CatsSuite.scala 33.33% <0%> (-36.67%) ⬇️
core/src/main/scala/cats/syntax/either.scala 86.76% <0%> (-12.5%) ⬇️
.../src/main/scala/cats/data/RepresentableStore.scala 83.33% <0%> (-4.17%) ⬇️
core/src/main/scala/cats/data/IorT.scala 97.74% <0%> (-0.05%) ⬇️
core/src/main/scala/cats/Eval.scala 98.78% <0%> (-0.05%) ⬇️
core/src/main/scala/cats/data/Ior.scala 98.52% <0%> (-0.02%) ⬇️
core/src/main/scala/cats/data/ContT.scala 100% <0%> (ø) ⬆️
laws/src/main/scala/cats/laws/MonadLaws.scala 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b57b2...21acd92. Read the comment docs.

LukaJCB
LukaJCB previously approved these changes Feb 6, 2019
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks a bunch Diogo! 👍

@dcastro
Copy link
Contributor Author

dcastro commented Feb 6, 2019

@LukaJCB Thanks! :)
I just realized this should probably also be done for Maps, what do you think? If so, should I add it here or in a different PR?

@LukaJCB
Copy link
Member

LukaJCB commented Feb 6, 2019

Good call, I think it's fine to add it to this PR if you like :)

@dcastro
Copy link
Contributor Author

dcastro commented Feb 13, 2019

@LukaJCB Apologies for the delay, it's done now :) I just reused the code from the TraverseFilter instance for SortedMap.

@LukaJCB LukaJCB self-assigned this Feb 13, 2019
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, but this looks very good :)

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. Thanks very much!

@kailuowang kailuowang merged commit 8b69af2 into typelevel:master Feb 27, 2019
@kailuowang kailuowang added this to the 2.0 milestone Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants